EMRY-016: Run metadata files (run.meta, config.json, summary.json) #61
No reviewers
Labels
No labels
blocked
bug
compat
docs
documentation
duplicate
emry-cli
emry-core
emry-engine
emry-ingest
emry-py
emry-store
emry-tui
emry-web
enhancement
good first issue
gpu-compute
help wanted
hpc
infra
integrations
invalid
needs-design
P0-blocker
P1-core
P2-enhanced
P3-future
performance
pull-request
python
pytorch
question
rust
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
femboy/emry!61
Loading…
Reference in a new issue
No description provided.
Delete branch "emry-016-run-metadata"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes EMRY-016 (#14). Branched off
main. Completes M1.What
emry-store/src/meta.rs:RunMetaFile+Summarystructs;run_dir_name/create_run_dirfor thelogs/{project}_{timestamp}/layout;write_jsonhelper.YYYYMMDD_HHMMSSformatter (Hinnantcivil_from_days) — avoids pulling in a date crate.emry-engine/src/session.rs:Engine::startwritesrun.meta(v4 run_id, start_time, mode) +config.json;finishwritessummary.json(duration, reason, steps, dropped).RunConfiggains amodefield.Verification
./scripts/pre-commit-rust.shgreen: clippy-D warnings, 43 engine + 17 store tests, meta.rs 100% / session.rs 96% lines, total 97.99%run.meta(v4 uuid + "file" mode) andsummary.json(200 steps, COMPLETED) contents.19700101_000000) and a known 2021 value.Review
A focused review verified the
civil_from_daystranscription against Hinnant's reference (era/day-of-era/month/day math, negative-z truncation, constants) — correct. Two 'important' findings examined and declined as non-bugs (.and()error priority is intentional; thecreate_run_dirclock-fallback concern is pre-existing and unused by the engine).