[A·M2.1 follow-up] Assert SSH KEXINIT on the wire in e2e test #24

New issue

Closed

opened 2026-06-25 05:10:23 +00:00 by vxfemboy · 0 comments

vxfemboy commented

2026-06-25 05:10:23 +00:00

(Migrated from github.com)

From the M2.1 review (minor). sends_banner_and_captures_client_version reads only the 21-byte version line and never drains/asserts the KEXINIT bytes that follow, giving false confidence the full handshake was transmitted. The pure kexinit_is_well_framed test covers framing, but the e2e test should read past the banner and assert the KEXINIT packet is present + well-framed on the wire.

From the M2.1 review (minor). `sends_banner_and_captures_client_version` reads only the 21-byte version line and never drains/asserts the KEXINIT bytes that follow, giving false confidence the full handshake was transmitted. The pure `kexinit_is_well_framed` test covers framing, but the e2e test should read past the banner and assert the KEXINIT packet is present + well-framed on the wire.